arnavsharma990 commented on PR #21214: URL: https://github.com/apache/nuttx/pull/21214#issuecomment-6532026492
Thanks for the review, @hartmannathan ! I've updated the PR to follow your suggestion. Compiler capability detection is now centralized in `include/nuttx/compiler.h` through `HAVE_EXPRESSION_STATEMENT`, and `math32.h` uses that macro instead of checking compiler identities directly. I've preserved the `sizeof(n)` portability fix and the optional Kconfig opt-out. Both optimized and fallback paths have been tested, and the updated changes are pushed in commit `286e7fd8ab`. really appreciate the guidance ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
