casaroli commented on code in PR #16312:
URL: https://github.com/apache/nuttx/pull/16312#discussion_r4434915725
##########
tools/Unix.mk:
##########
@@ -768,6 +768,7 @@ savedefconfig: apps_preconfig
$(Q) rm -f warning.tmp
$(Q) rm -f defconfig.tmp
$(Q) rm -f sortedconfig.tmp
+ $(info "The defconfig was generated successfully at $(PWD)/defconfig
.If you're building out-of-tree configuration, then don't forget to copy it
into your defconfig original location")
Review Comment:
`$(info)` runs when make expands the recipe, before `kconfig-tweak` and
`savedefconfig` run, so the message also prints when they fail. `$(PWD)` is the
directory of the caller: with `make -C nuttx savedefconfig` the path is wrong.
Fix: use `$(Q) echo "Saved $(CURDIR)/defconfig"` as the last recipe line,
and set the commit title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
