casaroli commented on code in PR #16930: URL: https://github.com/apache/nuttx/pull/16930#discussion_r4434946836
########## arch/arm/src/rp23xx/Make.defs: ########## @@ -23,6 +23,7 @@ include armv8-m/Make.defs CFLAGS += -Wno-array-bounds +LDFLAGS += --no-warn-rwx-segments Review Comment: master still warns on raspberrypi-pico-2:nsh and raspberrypi-pico-2-rv:nsh. arch/arm/src/common/Toolchain.defs and arch/risc-v/src/common/Toolchain.defs skip --no-warn-rwx-segments because these configs set CONFIG_BOOT_RUNFROMFLASH, and arch/arm/src/cmake/gcc.cmake:72 has the same condition, so a CMake build still warns with this PR. Fix: remove the condition in both Toolchain.defs and in gcc.cmake, as xiao suggested, instead of adding the flag per chip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
