casaroli commented on code in PR #20043: URL: https://github.com/apache/nuttx/pull/20043#discussion_r4434996660
########## include/nuttx/atomic.h: ########## @@ -27,7 +27,18 @@ * Included Files ****************************************************************************/ +#include <nuttx/config.h> + #include <stdbool.h> +#include <stdint.h> +#include <sys/types.h> + +#ifdef CONFIG_LIBC_ATOMIC_ARCH Review Comment: This PR deletes the `atomic_*_8` prototypes, and neither `include/nuttx/lib/arch_atomic.h` nor `arch/tricore/include/atomic.h` declares size 8. With `LIBC_ATOMIC_IRQ`, `LIBC_ATOMIC_HWSPINLOCK` or `LIBC_ATOMIC_ARCH` and `CONFIG_FS_PROFILER=y`, `atomic64_add()` in `fs/vfs/fs_profile.c` and `atomic64_read()` in `fs/procfs/fs_procfsprofile.c` call undeclared functions (an error with GCC 14). Fix: keep the declarations of the `atomic_*_8` functions that `arch_atomic64.c` defines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
