This is an automated email from the ASF dual-hosted git repository. casaroli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 22734606b46549ac23659cf14d690e51559f6347 Author: Brijesh Thakkar <[email protected]> AuthorDate: Sat Oct 24 15:25:04 2026 +0530 .github/workflows/build.yml: fail the job if NTFC cannot be installed The retry loop around "pip install ntfc" uses "&& break" and nothing after the loop checks the result, so when all three attempts fail the job carries on without NTFC. The failure then only shows up later, as a missing "ntfc" command in the citest run.sh script of the nuttx tree, which is hard to trace back to the network problem. Fail the job with a message after the last attempt, as apache/nuttx does. Part of apache/nuttx#17717 Assisted-by: Claude Code:claude-sonnet-5-5 Signed-off-by: Brijesh Thakkar <[email protected]> --- .github/workflows/build.yml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index eb90a6cab..af65867fa 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -376,10 +376,18 @@ jobs: export ARTIFACTDIR=`pwd`/buildartifacts for i in 1 2 3; do - python -m pip install \ + if python -m pip install \ --default-timeout=100 \ --retries 10 \ - ntfc==0.0.3 && break + ntfc==0.0.3; then + break + fi + + if [ "$i" -eq 3 ]; then + echo "Failed to install NTFC after $i attempts" + exit 1 + fi + echo "Retry $i failed..." sleep 5 done
