casaroli opened a new pull request, #3954:
URL: https://github.com/apache/nuttx-apps/pull/3954
## Summary
`NETUTILS_DHCPC` selects `NET_BINDTODEVICE`, which depends on
`NET_SOCKOPTS`. A configuration that enables the DHCP client and no other
option that selects `NET_SOCKOPTS` fails in `olddefconfig`:
```
warning: NET_BINDTODEVICE (defined at net/socket/Kconfig:88) has direct
dependencies NET_SOCKOPTS && NET with value n, but is currently being
y-selected by the following symbols:
- NETUTILS_DHCPC (defined at netutils/dhcpc/Kconfig:6), with value y,
direct dependencies NET_UDP (value: y), and select condition !NET_UDP_NO_STACK
&& NET_UDP (value: y)
make: *** [olddefconfig] Error 1
ERROR: failed to refresh
```
Since apache/nuttx#21320 removed the DNS client (which selected
`NET_SOCKOPTS`) from `lm3s6965-ek:qemu-protected`, that configuration fails
this way on NuttX master, so the arm-ti CI job fails. This PR makes
`NETUTILS_DHCPC` select `NET_SOCKOPTS` under the same condition as
`NET_BINDTODEVICE`, as `netutils/webclient` does.
## Impact
Kconfig only. A configuration that builds today already has `NET_SOCKOPTS`
when it has the DHCP client (or `olddefconfig` fails), so no other
configuration changes.
## Testing
NuttX master aa5b743e1e9, nuttx-apps master d40132fba, GCC 13.2,
`lm3s6965-ek:qemu-protected`:
| | apps master | this PR |
|---|---|---|
| `configure.sh` | fails in `olddefconfig` (above) | OK,
`CONFIG_NET_SOCKOPTS=y`, `CONFIG_NET_BINDTODEVICE=y` |
| build | - | OK, no warnings; kernel 128320 B of 131072 (kflash), user
121440 B |
| `make savedefconfig` | - | same as the defconfig |
`tools/checkpatch.sh -c -u -m -g` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
