casaroli commented on code in PR #16723:
URL: https://github.com/apache/nuttx/pull/16723#discussion_r4439706009
##########
tools/espressif/check_esptool.py:
##########
@@ -55,13 +55,13 @@ def check_version(min_esptool_version: str) -> bool:
False: package installed and up-to-date
"""
try:
- # Run esptool.py version command
+ # Run esptool version command
result = subprocess.run(
- ["esptool.py", "version"], capture_output=True, text=True,
check=True
+ ["esptool", "version"], capture_output=True, text=True, check=True
Review Comment:
esptool 4.x installs only `esptool.py`; it has no `esptool` command.
ESPTOOL_MIN_VERSION is still 4.8.0 and the ESP32 and ESP32-C3 docs say `pip
install esptool>=4.8.1`. With esptool 4.8 this check prints "esptool not found"
and exits 1, so `make` stops for every Espressif board.
Fix: fall back to `esptool.py` when `esptool` is not found, as
tools/espressif/espressif_mkimage.cmake does with `find_program(ESPTOOL NAMES
esptool esptool.py)`; or raise ESPTOOL_MIN_VERSION to 5.0.0 and update the docs
in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
