casaroli opened a new pull request, #3958:
URL: https://github.com/apache/nuttx-apps/pull/3958

   ## Summary
   
   The cmocka syscall test `pipe02` writes to the read end and reads from the 
write end of a pipe, and expects `EACCES`. POSIX specifies `EBADF` for both: 
write(): "[EBADF] The fildes argument is not a valid file descriptor open for 
writing."; read(): "[EBADF] The fildes argument is not a valid file descriptor 
open for reading." apache/nuttx#21367 changes NuttX to return `EBADF`. This PR 
changes the test to expect `EBADF`.
   
   depends-on: apache/nuttx/pull/21367
   
   ## Impact
   
   Test only (`testing/testsuites`, `CONFIG_CM_SYSCALL_TEST`). No CI 
configuration enables this test. With NuttX before apache/nuttx#21367, `pipe02` 
fails; merge it after that PR.
   
   ## Testing
   
   qemu-armv8a:nsh (flat, arm64, QEMU with HVF) with `CONFIG_CM_SYSCALL_TEST` 
(this PR is on nuttx-apps master 54374b3b2), command `cmocka -s 
cmocka_syscall_test -t test_nuttx_syscall_pipe0.*`:
   
   | nuttx | nuttx-apps | pipe01 | pipe02 |
   | --- | --- | --- | --- |
   | master 1b0691e870d | master | OK | OK |
   | apache/nuttx#21367 | master | OK | FAILED (`pipe_test.c:92`, expects 
`EACCES`) |
   | apache/nuttx#21367 | this PR | OK | OK |
   
   `tools/checkpatch.sh -c -u -m -g` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to