SofianElmotiem opened a new pull request, #21392: URL: https://github.com/apache/nuttx/pull/21392
The RX path took the frame length straight from the RX status FIFO and copied that many bytes into pktbuf. Nothing actually stopped it from going past the end: the SPI path only had a DEBUGASSERT (gone in normal builds) and the SQI path had no check at all. With the default 590 byte packet size, pktbuf is 596 bytes, so a normal full-size Ethernet frame was enough to scribble over the watchdog and work structs after it. So now: - frames bigger than MAX_NETDEV_PKTSIZE + 4 (CRC) get dropped, and their data is skipped with RX_FFWD in RX_DP_CTRL so the FIFO stays in sync - frames shorter than an Ethernet header + CRC are still read out but not passed up, since pktlen - 4 used to wrap d_len around for tiny lengths - the remaining DEBUGASSERT now covers both SPI and SQI Fixes #21112 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary *Update this section with information on why change is necessary, what it exactly does and how, if new feature shows up, provide references (dependencies, similar problems and solutions), etc.* ## Impact *Update this section, where applicable, on how change affects users, build process, hardware, documentation, security, compatibility, etc.* ## Testing *This section should provide a detailed description of what you did to verify your changes work and do not break existing code.* *Please provide information about your host machine, the board(s) you tested your changes on, and how you tested. Logs should be included.* *For example, when changing something in the core OS functions, you may want to run the OSTest application to verify that there are no regressions. Changes to ADC code may warrant running the `adc` example. Adding a new uORB driver may require that you run `uorb_listener` to verify correct operation.* *Pure documentation changes can just be tested with `make html` (see docs) and verification of the correct format in your browser.* **_PRs without testing information will not be accepted. We will request test logs._** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
