no1wudi opened a new pull request, #21378: URL: https://github.com/apache/nuttx/pull/21378
## Summary The board carried its own copy of the common `esp32s3_qmi8658.c` driver. The two files are functionally identical; the only difference is where `QMI8658_I2C_PORT` and `QMI8658_I2C_ADDR` are taken from: the board-local copy includes a private board header, the common driver expects them from `<arch/board/board.h>`. Define the two macros in the board's `include/board.h` (as `esp32s3-ws-lcd128` already does) and drop the board-local copy. This also fixes the CMake build of the `qmi8658` configuration: the common source, which was dead code so far (no board provided the expected defines), needs those defines to compile. ## Impact `lckfb-szpi-esp32s3` only. Make builds keep compiling exactly one QMI8658 driver (now the common one). No upstream file outside the board directory changes. ## Testing - `lckfb-szpi-esp32s3:qmi8658` builds with Make and CMake, both producing identical `text` (158242 bytes). - The CMake-built firmware was flashed to hardware: `/dev/uorb/sensor_accel0` and `sensor_gyro0` register (the driver's WHO_AM_I check passes), and `uorb_listener` streams accelerometer data (z \u2248 1 g at rest, chip temperature \u2248 30.5 \u00b0C) and gyroscope data. Assisted-by: pi:glm-5.3-flash Signed-off-by: Huang Qi <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
