cederom commented on code in PR #3962: URL: https://github.com/apache/nuttx-apps/pull/3962#discussion_r4453257786
########## system/gdbstub/gdbstub.c: ########## @@ -92,6 +92,28 @@ static ssize_t gdb_send(FAR void *priv, FAR const char *buf, size_t len) return len; } +#ifdef CONFIG_NET Review Comment: really necessary to double the whole function if only one internal call parameter differs? what is more one function will always be present and the other only when CONFIG_NET is enabled.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
