casaroli commented on code in PR #21346: URL: https://github.com/apache/nuttx/pull/21346#discussion_r4470507150
########## boards/arm/stm32g4/nucleo-g491re/src/CMakeLists.txt: ########## @@ -0,0 +1,38 @@ +# ############################################################################## +# boards/arm/stm32g4/nucleo-g491re/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ############################################################################## + + Review Comment: The `check` job fails here: cmake-format wants one blank line after the license, and there are two. Fix: delete line 23. ########## arch/arm/src/common/stm32/stm32_allocateheap_m3m4_v1.c: ########## @@ -522,6 +522,8 @@ #if defined(CONFIG_STM32_STM32G47XX) # define SRAM1_END 0x20020000 +#elif defined(CONFIG_STM32_STM32G49XX) +# define SRAM1_END 0x2001c000 Review Comment: `SRAM1_END` 0x2001c000 includes the CCM alias at 0x20018000-0x2001bfff (see the comment in scripts/ld.script), and `SRAM2` at 0x10000000 is the same 16 KiB. With `CONFIG_MM_REGIONS=2` the heap gets that memory twice; the ld.script comment also says that CCM stays reserved. Fix: set `SRAM1_END` to 0x20018000. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
