casaroli commented on code in PR #3973: URL: https://github.com/apache/nuttx-apps/pull/3973#discussion_r4473343233
########## mlearning/cmsis-nn/Makefile: ########## @@ -24,7 +24,7 @@ include $(APPDIR)/Make.defs CMSIS_NN = cmsis-nn/Source -CMSIS_NN_VER = 72e1ebf623ab1660a3e14e4e36fdcddce46f1991 +CMSIS_NN_VER = 18bb0fd4ecea4b17a5a3c444c8d3a8cf28b1e68f Review Comment: This CMSIS-NN pin breaks the build with CONFIG_ARM_NEON. The new `arm_nnfunctions.h` adds `const cmsis_nn_dims *upscale_dims` to arm_convolve_s8(), and `mlearning/tflite-micro/operators/neon/arm_convolve_s8.c:41` still has the old list: `error: conflicting types for 'arm_convolve_s8'`. The same file compiles with the previous `CMSIS_NN_VER`. Fix: add `upscale_dims` to arm_convolve_s8() in that file, and handle it as the new CMSIS-NN arm_convolve_s8() does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
