casaroli commented on code in PR #21493:
URL: https://github.com/apache/nuttx/pull/21493#discussion_r4492278382


##########
libs/libc/stream/lib_libvsprintf.c:
##########
@@ -124,6 +124,18 @@
 #define FL_ALT_IS_HEX(f)   (FL_ALT_FORM == 0 || !HAVE_OCTAL_OUTPUT || \
                             ((f) & FL_ALTHEX) != 0)
 
+/* An integer conversion with a feature that is off prints a question mark.
+ * A flag that is 0 lets the compiler remove the code of its feature.
+ */
+
+#ifdef CONFIG_LIBC_PRINTF_INT_PRECISION
+#  define FL_INT_PREC      FL_PREC
+#  define FL_INT_UNAVAIL   0

Review Comment:
   Done.



##########
libs/libc/stream/lib_libvsprintf.c:
##########
@@ -130,12 +130,22 @@
 
 #ifdef CONFIG_LIBC_PRINTF_INT_PRECISION
 #  define FL_INT_PREC      FL_PREC
-#  define FL_INT_UNAVAIL   0
+#  define FL_NO_INT_PREC   0
 #else
 #  define FL_INT_PREC      0
-#  define FL_INT_UNAVAIL   FL_PREC
+#  define FL_NO_INT_PREC   FL_PREC

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to