anchao commented on issue #21467:
URL: https://github.com/apache/nuttx/issues/21467#issuecomment-6648392496
@casaroli
Thanks for putting together such a detailed plan, and for the comprehensive
test results.
Just to clarify my own intention behind #21340: my main goals were to make
vsprintf_internal() easier to modularize and read through configuration, and at
the same time to improve performance and reduce stack usage. Beyond that I
don't have a strong attachment to a particular structure.
[One thing I'm not sure about, though, is how your plan interacts with
#21340 — specifically whether it matters if your refactoring is done before or
after my change is (or isn't) merged. If your ordering assumptions depend on my
PR, it would be good to align on that.]
To be clear, I don't need my PR to be merged at all. The current changes
were largely produced with AI assistance anyway, so there's no investment on my
side to protect. If your framework/structure is better and can also address the
goals I was trying to solve (modularity, readability, performance, stack
usage), then I'm happy to go with your approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
