casaroli commented on code in PR #3985:
URL: https://github.com/apache/nuttx-apps/pull/3985#discussion_r4497807801
##########
interpreters/python/Makefile:
##########
@@ -91,6 +91,7 @@ $(CPYTHON_UNPACKNAME): $(CPYTHON_ZIP)
$(Q) patch -p1 -d $(CPYTHON_UNPACKNAME) <
patch$(DELIM)0019-undef-get_errno-set_errno-to-avoid-nuttx-macro-coll.patch
$(Q) patch -p1 -d $(CPYTHON_UNPACKNAME) <
patch$(DELIM)0020-ctypes-skip-pythonapi-on-nuttx.patch
$(Q) patch -p1 -d $(CPYTHON_UNPACKNAME) <
patch$(DELIM)0021-posixmodule-ignore-utime-enosys-on-nuttx.patch
+ $(Q) patch -p1 -d $(CPYTHON_UNPACKNAME) <
patch$(DELIM)0022-hacl-krml-avoid-uint128-typedef-conflict-with-nuttx-stdint.patch
Review Comment:
The CI check job fails with "Makefile modified but
interpreters/python/CMakeLists.txt was not updated". CMake needs no change
here, because line 37 of CMakeLists.txt already applies every patch/*.patch.
Fix: add [skip-cmake-parity] to the commit message, with that reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
