CV-Bowen opened a new pull request, #3971: URL: https://github.com/apache/nuttx-apps/pull/3971
## Summary Remove the `panic` subcommand of the `rpmsg` and `rptun` nsh commands and drop it from their help text. Panicking a remote core from the shell is a debug convenience that the rpmsg/rptun drivers no longer want to carry; `rpmsg dump`/`ping`/`test` and `rptun start`/`stop`/`reset` stay. ## Impact nsh only: `rpmsg panic` and `rptun panic` now print "argument invalid". The ioctls `RPMSGIOC_PANIC`/`RPTUNIOC_PANIC` are left in the kernel. ## Testing Host: Ubuntu 22.04.5 LTS x86_64, QEMU version 10.2.1, sim: cc (Ubuntu 13.1.0-8ubuntu1~22.04) 13.1.0, qemu-armv8a: aarch64-none-elf-gcc (Arm GNU Toolchain 12.2.Rel1 (Build arm-12.24)) 12.2.1 20221205 sim:rpserver + sim:rpproxy: ``` server> rpmsg panic /dev/rpmsg/proxy nsh: panic: argument invalid server> rptun panic /dev/rptun/proxy nsh: panic: argument invalid server> help rpmsg rpmsg usage: rpmsg <dump|ping> <path|all> [value|times length ack sleep] server> help rptun rptun usage: rptun <start|stop|reset|dump|ping|test> <path|all> [value|times length ack sleep] server> rpmsg ping /dev/rpmsg/proxy 1 64 3 0 [ 5.310079] [server] ping times: 1 ``` Baseline: No regression in rpmsg: sim:rpserver/rpproxy and qemu-armv8a:rpserver/rpproxy boot and pass the fixed rpmsg cases (dump, ping, rpmsgfs; 15/15). qemu-armv8a was built with LIBC_ENVPATH and BINFMT_CHECKEXEC disabled, which current master needs for nxinit to start nsh there; unrelated to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
