casaroli commented on code in PR #21428: URL: https://github.com/apache/nuttx/pull/21428#discussion_r4505484771
########## sched/clock/clock_perf.c: ########## @@ -32,13 +32,23 @@ #include <nuttx/sched.h> #include <nuttx/wdog.h> -#ifndef CONFIG_ARCH_PERF_EVENTS_USER_ACCESS - /**************************************************************************** * Preprocessors ****************************************************************************/ -# if defined(CONFIG_PERF_OVERFLOW_CORRECTION) && ULONG_MAX != UINT64_MAX +/* Use up_perf_*() only when they count. Else use the system ticks. */ + +#if defined(CONFIG_ARCH_HAVE_PERF_EVENTS) +# ifdef CONFIG_ARCH_PERF_EVENTS Review Comment: `ARCH_PERF_EVENTS` depends on `ARCH_HAVE_PERF_EVENTS`. A chip such as FE310 selects `ALARM_ARCH` but not `ARCH_HAVE_PERF_EVENTS`, so its only `up_perf_*()` are the oneshot ones in arch_alarm.c; with only `ARCH_PERF_EVENTS`, its `perf_gettime()` would drop to the system tick. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
