CV-Bowen opened a new pull request, #21557:
URL: https://github.com/apache/nuttx/pull/21557
## Summary
Remove the rpmsg_virtio_lite transport and its front ends:
- `drivers/rpmsg/rpmsg_virtio_lite.c`,
`include/nuttx/rpmsg/rpmsg_virtio_lite.h`
- `drivers/rpmsg/rpmsg_virtio_ivshmem.c`,
`include/nuttx/rpmsg/rpmsg_virtio_ivshmem.h`
and its registration in `drivers/pci/pci_drivers.c`
- `arch/sim/src/sim/sim_rpmsg_virtio.c` and its sim bringup
- `sim:rpserver_virtio` and `sim:rpproxy_virtio`, the only in-tree users
rpmsg_virtio_lite is a second rpmsg virtio transport that runs without
rptun, kept as a lighter option for small systems. It has its own rx
thread, PM and dump code, so every fix and ops change in `rpmsg_virtio`
has to be ported to it again, and the two keep drifting apart.
We think the better way to serve small systems is to make rptun itself
lighter, so one transport covers both cases, instead of keeping a
separate lite copy.
Without lite, the two `_virtio` configs would be `sim:rpserver` /
`sim:rpproxy` minus rptun, i.e. with no rpmsg link at all, so they are
removed rather than converted; use `sim:rpserver` / `sim:rpproxy`. The
`.github/CODEOWNERS` lines for the removed files are dropped.
The commit carries `[skip-cmake-parity]`: `arch/sim/src/Makefile` is
paired with `arch/sim/src/sim/CMakeLists.txt`, which is updated in the
same commit, but the parity check looks for
`arch/sim/src/CMakeLists.txt`.
## Impact
- Removed Kconfig: `RPMSG_VIRTIO_LITE`, `RPMSG_VIRTIO_LITE_PRIORITY`,
`RPMSG_VIRTIO_LITE_STACKSIZE`, `RPMSG_VIRTIO_LITE_PM`,
`RPMSG_VIRTIO_LITE_PM_AUTORELAX`, `RPMSG_VIRTIO_IVSHMEM*`.
- Removed API: `rpmsg_virtio_lite_*`,
`pci_register_rpmsg_virtio_ivshmem_driver()`,
`sim_rpmsg_virtio_init()`.
- Out-of-tree boards on rpmsg_virtio_lite move to rptun +
`CONFIG_DRIVERS_VIRTIO_RPMSG`; for ivshmem, `rptun_ivshmem`.
- Removed configs: `sim:rpserver_virtio`, `sim:rpproxy_virtio`
(use `sim:rpserver`, `sim:rpproxy`).
## Testing
Host: Ubuntu 22.04.5 LTS x86_64, QEMU version 10.2.1, sim: cc (Ubuntu
13.1.0-8ubuntu1~22.04) 13.1.0, qemu-armv8a: aarch64-none-elf-gcc (Arm GNU
Toolchain 12.2.Rel1 (Build arm-12.24)) 12.2.1 20221205
`git grep` for `VIRTIO_LITE`, `VIRTIO_IVSHMEM`, `sim_rpmsg_virtio`,
`rpmsg_virtio_lite`, `rpmsg_virtio_ivshmem`, `rpserver_virtio`,
`rpproxy_virtio` outside
`Documentation/ReleaseNotes` returns nothing.
No regression in rpmsg: sim:rpserver/rpproxy and
qemu-armv8a:rpserver/rpproxy boot and pass the fixed rpmsg cases (dump, ping,
rpmsgfs; 15/15). qemu-armv8a was built with LIBC_ENVPATH and BINFMT_CHECKEXEC
disabled, which current master needs for nxinit to start nsh there; unrelated
to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
