casaroli opened a new pull request, #21566:
URL: https://github.com/apache/nuttx/pull/21566
## Summary
`nuttx_add_application()` takes `UID`, `GID` and `MODE`, but uses them only
for the `nx_uid`, `nx_gid` and `nx_mode` symbols of a loadable ELF. For a
builtin application they are lost, so the builtin list of apps cannot give the
builtin its file owner and mode, as the make build does from `UID`, `GID` and
`MODE` in the Makefile (for example examples/hello with
`EXAMPLES_HELLO_RESTRICTED`: mode 0744).
This PR stores them as the target properties `APP_UID`, `APP_GID` and
`APP_MODE`, next to `APP_PRIORITY` and `APP_STACK`. apache/nuttx-apps#NNNN
reads them.
## Impact
CMake build only. A property is set only if the application gives the value.
Nothing in nuttx reads the properties, so the build output does not change
without the apps PR. The apps PR works without this PR (it then uses 0, 0 and
0555).
## Testing
CMake configure of qemu-armv8a:rpserver with `EXAMPLES_HELLO_RESTRICTED=y`
and apache/nuttx-apps#NNNN: `builtin_list.h` has `{ "hello", 100, 8192,
hello_main, 0, 0, 484 },` (484 = 0744); without this PR, `0, 0, 0555`.
`tools/checkpatch.sh -c -u -m -g` passes (cmake-format included).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
