casaroli commented on code in PR #21463: URL: https://github.com/apache/nuttx/pull/21463#discussion_r4490163382
########## arch/arm/src/common/arm_checkstack.c: ########## @@ -53,24 +53,17 @@ * Name: arm_color_intstack * * Description: - * Set the interrupt stack to a value so that later we can determine how - * much stack space was used by interrupt handling logic + * Set the interrupt stack of the calling CPU to a value so that later we + * can determine how much stack space was used by interrupt handling logic. + * Another CPU can be in an interrupt handler at this time, so its stack + * is not touched. Each CPU calls this before it enables its interrupts. * ****************************************************************************/ #if defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3 Review Comment: It stays under `#ifdef CONFIG_STACK_COLORATION` (arm_checkstack.c:42), and arm_internal.h defines it empty without the option, so nothing changes there. With the option, each CPU colors one stack instead of all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
