xiaoxiang781216 commented on code in PR #21496:
URL: https://github.com/apache/nuttx/pull/21496#discussion_r4489766904
##########
arch/tricore/src/common/tricore_doirq.c:
##########
@@ -41,6 +41,13 @@
#include "tricore_internal.h"
+/* The interrupt entry still uses the iLLD until it is native */
Review Comment:
why not remove directly until iLLD is finally dropped? instead dup in two
places.
##########
arch/tricore/src/common/tricore_trapcall.c:
##########
@@ -100,12 +100,32 @@
# define tricore_trap_return() __asm__ volatile ("ji %a11")
#endif
+/* Smallest FCU pool: two CSAs for the trapped context, the rest for the
+ * panic path.
+ */
+
+#define TRICORE_FCU_CSA_MINNUM 20
+
/****************************************************************************
* Private Data
****************************************************************************/
static struct tricore_trap_s g_trapinfo;
+/* FCU pool, also read by tricore_fcu_entry in tricore_vectors.S/.asm */
+
+uintptr_t *g_tricore_fcu_pool;
+static size_t g_tricore_fcu_num;
+
+/* One CSA more than needed, so the start can be aligned to 64 bytes at run
+ * time; not every toolchain honours a 64-byte alignment request here.
+ */
+
+#if CONFIG_TRICORE_FCU_CSA_NUM > 0
+static uintptr_t
+g_fcu_csa[(CONFIG_TRICORE_FCU_CSA_NUM + 1) * TC_CONTEXT_REGS];
Review Comment:
add align and remove the align code at line 618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
