Junbo-Zheng commented on code in PR #21541: URL: https://github.com/apache/nuttx/pull/21541#discussion_r4509593917
########## boards/xtensa/esp32/esp32-m5-stickc-plus/src/esp32_axp192.c: ########## @@ -0,0 +1,170 @@ +/**************************************************************************** + * boards/xtensa/esp32/esp32-m5-stickc-plus/src/esp32_axp192.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/* Minimal board-level setup of the AXP192 PMIC. + * + * On the M5StickC Plus the AXP192 supplies the LCD: LDO2 drives the + * backlight and LDO3 the panel logic. Neither rail is guaranteed to be on + * after a cold power-up, so they must be enabled before the LCD driver + * talks to the panel. + */ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdint.h> +#include <errno.h> +#include <syslog.h> + +#include <nuttx/i2c/i2c_master.h> + +#include "esp32_i2c.h" +#include "esp32-m5-stickc-plus.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define AXP192_I2C_ADDR 0x34 +#define AXP192_I2C_FREQ 400000 + +#define AXP192_POWER_OUT_CTL 0x12 /* DCDC1/2/3, LDO2/3, EXTEN enables */ Review Comment: > The Check job fails here: codespell reports "EXTEN ==> EXTEND, EXTENT" on this comment, so checkpatch does not pass (the PR body says it passes on all touched C files). Fix: reword the comment, for example "DCDC1/2/3, LDO2/3 and external output enables", and update the Testing section. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
