JianyuWang0623 opened a new pull request, #21590:
URL: https://github.com/apache/nuttx/pull/21590
## Summary
PR #14999 moved GNSS to a per-topic `nbuffer[]` but missed
`drivers/sensors/goldfish_gnss_uorb.c`, which still calls `gnss_register()`
in the old 3-argument form and no longer builds with
`CONFIG_SENSORS_GOLDFISH_GNSS=y`.
Convert goldfish GNSS the same way as fakesensor: pass one `batch_number`
entry per `SENSOR_GNSS_IDX_*` topic with `nitems()` as the count.
## Impact
- drivers/sensors/goldfish_gnss_uorb.c only; fixes its build with
CONFIG_SENSORS_GOLDFISH_GNSS=y.
- Boards not enabling CONFIG_SENSORS_GOLDFISH_GNSS are unaffected.
## Testing
Build Host: Ubuntu 22.04 x86_64, arm-none-eabi-gcc 13.2
Target: qemu-armv7a:nsh with CONFIG_SENSORS=y, CONFIG_SENSORS_GNSS=y,
CONFIG_SENSORS_GOLDFISH_GNSS=y, CONFIG_GNSSUTILS_MINMEA_LIB=y
Before (master, build fails):
```
sensors/goldfish_gnss_uorb.c:238:44: warning: passing argument 3 of
'gnss_register' makes pointer from integer without a cast [-Wint-conversion]
sensors/goldfish_gnss_uorb.c:238:10: error: too few arguments to function
'gnss_register'
```
After: full clean build passes (`LD: nuttx`), `goldfish_gnss_uorb.o` is
linked into the image.
`./tools/checkpatch.sh -c -u -m -g HEAD~1..HEAD` passes.
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
