xiaoxiang781216 commented on code in PR #8738:
URL: https://github.com/apache/nuttx/pull/8738#discussion_r1126227237
##########
drivers/lcd/memlcd.c:
##########
@@ -165,6 +182,7 @@ static int memlcd_setcontrast(struct lcd_dev_s *dev,
unsigned int contrast);
* Private Data
****************************************************************************/
+static uint8_t _sharpmem_vcom;
static uint8_t g_runbuffer[MEMLCD_BPP * MEMLCD_XRES / 8];
Review Comment:
let's move the global variables into memlcd_dev_s
##########
drivers/lcd/memlcd.c:
##########
@@ -365,13 +418,10 @@ static inline void memlcd_clear(FAR struct memlcd_dev_s
*mlcd)
static int memlcd_extcominisr(int irq, FAR void *context, void *arg)
{
- static bool pol = 0;
- struct memlcd_dev_s *mlcd = &g_memlcddev;
#ifdef CONFIG_MEMLCD_EXTCOMIN_MODE_HW
-# error "CONFIG_MEMLCD_EXTCOMIN_MODE_HW unsupported yet!"
/* Start a worker thread, do it in bottom half? */
-
#else
+ static bool pol = 0;
Review Comment:
move pol to memlcd_dev_s too
##########
drivers/lcd/memlcd.c:
##########
@@ -365,13 +418,10 @@ static inline void memlcd_clear(FAR struct memlcd_dev_s
*mlcd)
static int memlcd_extcominisr(int irq, FAR void *context, void *arg)
{
- static bool pol = 0;
- struct memlcd_dev_s *mlcd = &g_memlcddev;
#ifdef CONFIG_MEMLCD_EXTCOMIN_MODE_HW
Review Comment:
```suggestion
#ifndef CONFIG_MEMLCD_EXTCOMIN_MODE_HW
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
