xiaoxiang781216 commented on code in PR #1640: URL: https://github.com/apache/nuttx-apps/pull/1640#discussion_r1129289279
########## nshlib/nsh_syscmds.c: ########## @@ -579,6 +581,8 @@ int cmd_uname(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) /* Process each option */ first = true; + lib_memoutstream(&stream, alloca(sizeof(struct utsname)), Review Comment: is it enough to allocate struct utsname in the extreme case? since we add more ' ' and '\n'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
