xiaoxiang781216 commented on code in PR #8942:
URL: https://github.com/apache/nuttx/pull/8942#discussion_r1155252516
##########
boards/arm/imxrt/imxrt1064-evk/src/imxrt_boot_image.c:
##########
@@ -137,17 +137,18 @@ static void systick_disable(void)
int board_boot_image(const char *path, uint32_t hdr_size)
{
static struct arm_vector_table vt;
- int fd;
+ struct file file;
ssize_t bytes;
+ int ret;
- fd = open(path, O_RDONLY | O_CLOEXEC);
- if (fd < 0)
+ ret = file_open(&file, path, O_RDONLY | O_CLOEXEC);
+ if (ret < 0)
{
- syslog(LOG_ERR, "Failed to open %s with: %d", path, fd);
- return fd;
+ syslog(LOG_ERR, "Failed to open %s with: %d", path, ret);
+ return ret;
}
- bytes = pread(fd, &vt, sizeof(vt), hdr_size);
+ bytes = file_pread(&file, &vt, sizeof(vt), hdr_size);
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
