hartmannathan commented on code in PR #8945:
URL: https://github.com/apache/nuttx/pull/8945#discussion_r1155877905
##########
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##########
@@ -866,30 +885,25 @@ void stm32_stdclockconfig(void)
{
}
- /* Over-drive is needed if
- * - Voltage output scale 1 mode is selected and SYSCLK frequency is
- * over 400 MHz.
- */
+#if STM32_VOS_OVERDRIVE && (STM32_PWR_VOS_SCALE == PWR_D3CR_VOS_SCALE_1)
+ /* Over-drive support for VOS1 */
- if ((STM32_PWR_VOS_SCALE == PWR_D3CR_VOS_SCALE_1) &&
- STM32_SYSCLK_FREQUENCY > 400000000)
- {
- /* Enable System configuration controller clock to Enable ODEN */
+ /* Enable System configuration controller clock to Enable ODEN */
- regval = getreg32(STM32_RCC_APB4ENR);
- regval |= RCC_APB4ENR_SYSCFGEN;
- putreg32(regval, STM32_RCC_APB4ENR);
+ regval = getreg32(STM32_RCC_APB4ENR);
+ regval |= RCC_APB4ENR_SYSCFGEN;
+ putreg32(regval, STM32_RCC_APB4ENR);
- /* Enable Overdrive to extend the clock frequency up to 480 MHz. */
+ /* Enable Overdrive */
Review Comment:
Hmm, maybe it's better to update the comment to explain it's required for
greater than 400 MHz operation and/or external ULPI. This way the rationale
will be documented together with the code. Otherwise someone in the future
could think it's a mistake and undo the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
