pkarashchenko commented on code in PR #9510: URL: https://github.com/apache/nuttx/pull/9510#discussion_r1225493156
########## libs/libc/string/lib_memmem.c: ########## @@ -42,6 +42,7 @@ * ****************************************************************************/ +#undef memmem /* See mm/README.txt */ Review Comment: @xiaoxiang781216 in general I see the `#undef xxxx /* See mm/README.txt */` used in `string.h` APIs, but the content of `mm/README.txt` has description only for APIs from `stdlib.h`. I'm not sure if the same is applied to `string.h` APIs so maybe `libs/libc/string` should be cleaned up instead of adding undefs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
