acassis commented on PR #9523: URL: https://github.com/apache/nuttx/pull/9523#issuecomment-1595772200
> @acassis wouldn't it make more sense to keep my patch and add fb_register to those boards not calling it rather than to remove it from esp32_bringup.c? I don't think we should bind the LCD char device to the the framebuffer char device - we can initialize and use the framebuffer even if we decide not to register an LCD char device. fb_register() only will be called for boards that enabled CONFIG_VIDEO_FB and CONFIG_LCD_FRAMEBUFFER, so in this case you we really requesting to create a /dev/fb0 device. If you don't want to bind to framebuffer device, just don't enable the CONFIG_VIDEO_FB. Keeping it at common/ and removing for each board's esp32_bringup.c avoid code duplication too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
