raiden00pl commented on PR #9782: URL: https://github.com/apache/nuttx/pull/9782#issuecomment-1635524778
> > Usage: > > `python tools/nxmake2cmake.py arch/arm/src/stm32f0l0g0` > > Coincidentally, the example provided above `include`s another `Makefile`: > > https://github.com/apache/nuttx/blob/f43c7e99bedd8ea0cc2e3e6c2c796c38dbb8f354/arch/arm/src/stm32f0l0g0/Make.defs#L21 > > [The file referred to above](https://github.com/apache/nuttx/blob/f43c7e99bedd8ea0cc2e3e6c2c796c38dbb8f354/arch/arm/src/armv6-m/Make.defs) seems to define another bunch of source files. However, `nxmake2cmake.py` seems to explicitly ignore lines with `include`, so none of these source files are being appended to the generated `CMakeLists.txt`. Is this intended? The included Makefile is handled elsewhere (https://github.com/apache/nuttx/blob/f43c7e99bedd8ea0cc2e3e6c2c796c38dbb8f354/arch/arm/src/cmake/armv7-m.cmake), so we can just ignore it. > Nit: similar tools, such as parsememdump.py, have their +x bit set. Considering nxmake2cmake.py also defines a shebang (i.e., #!/usr/bin/env python3), maybe this was a leftover? I see that all .py files in `tools/` have `+x` set, so I changed it here as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
