Phoslight commented on code in PR #18120:
URL: https://github.com/apache/tvm/pull/18120#discussion_r2195452295
##########
tests/python/relax/test_dataflow_rewriter.py:
##########
@@ -1169,9 +1171,9 @@ def expected(
],
)
- v = embedded_qkv_tuple[2]
q_embed = embedded_qkv_tuple[0]
k_embed = embedded_qkv_tuple[1]
+ v = embedded_qkv_tuple[2]
Review Comment:
Thank you for the investigation. I'm using the `main` branch, but the test
still fails after switching to the `0.21.dev0` tag. The code you posted is
indeed the one generated by `expected()`, and it is the same as the second
snippet I shared earlier, as you may have noticed :).
I was wondering if you could reproduce the test failure mentioned in this PR
by running `<python> -m pytest -s -v
tests/python/relax/test_dataflow_rewriter.py::test_rewrite_of_implicit_tuple_with_three_elements`?
If you can't, then that would be a bit unexpected.
But if you can, from what I understand, the issue here may still be that
`before()` produces a natural variable definition order of `0 -> 1 -> 2`,
while`expected()` generates `2 -> 1 -> 0`.
Please let me know if I misunderstood your concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
