Ubospica commented on code in PR #18289:
URL: https://github.com/apache/tvm/pull/18289#discussion_r2335058766
##########
ffi/docs/guides/python_guide.md:
##########
@@ -188,8 +188,7 @@ public:
TestIntPairObj(int64_t a, int64_t b) : a(a), b(b) {}
// Required: declare type information
- static constexpr const char* _type_key = "testing.TestIntPair";
- TVM_FFI_DECLARE_FINAL_OBJECT_INFO(TestIntPairObj, tvm::ffi::Object);
+TVM_FFI_DECLARE_OBJECT_INFO_FINAL("testing.TestIntPair", TestIntPairObj,
tvm::ffi::Object);
Review Comment:
Ditto. In markdown we don't have auto formatting.
##########
ffi/docs/guides/cpp_guide.md:
##########
@@ -105,9 +105,7 @@ class MyIntPairObj : public tvm::ffi::Object {
// Required: declare type information
// to register a dynamic type index through the system
- static constexpr const char* _type_key = "example.MyIntPair";
- // This macro registers the class with the FFI system to set up the right
type index
- TVM_FFI_DECLARE_FINAL_OBJECT_INFO(MyIntPairObj, tvm::ffi::Object);
+TVM_FFI_DECLARE_OBJECT_INFO_FINAL("example.MyIntPair", MyIntPairObj,
tvm::ffi::Object);
Review Comment:
We need formatting here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
