altanh commented on a change in pull request #7370:
URL: https://github.com/apache/tvm/pull/7370#discussion_r567156926
##########
File path: src/parser/tokenizer.h
##########
@@ -212,6 +212,25 @@ struct Tokenizer {
}
}
+ Token ParseNumber(bool is_pos) {
+ std::stringstream ss;
+ while (More() && IsNumeric(Peek())) {
Review comment:
out of the scope of this PR, but I imagine this is too loose in terms of
accepting weird strings that satisfy the `IsNumeric` constraint, such as
`1e2e3+..2`. That being said, `stod("1e2e3+..2")` returns `100`, so I guess
it's alright lol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
