comaniac commented on a change in pull request #7577:
URL: https://github.com/apache/tvm/pull/7577#discussion_r589619283
##########
File path: docs/deploy/vitis_ai.rst
##########
@@ -196,7 +196,7 @@ Hardware setup and docker build
pip3 install -e . --user
Edge (DPUCZDX8G)
-^^^^^^^^^^^^^^^^
+~~~~~~~~~~~~~~~~~
Review comment:
```suggestion
~~~~~~~~~~~~~~~~
```
##########
File path: python/tvm/driver/tvmc/composite_target.py
##########
@@ -22,7 +22,7 @@
from tvm.relay.op.contrib.arm_compute_lib import partition_for_arm_compute_lib
from tvm.relay.op.contrib.ethosn import partition_for_ethosn
from tvm.relay.op.contrib.vitis_ai import partition_for_vitis_ai
-from tvm.contrib.target import vitis_ai
+from tvm.contrib.target import vitis_ai # pylint: disable=unused-import
Review comment:
Actually I was thinking how could we avoid adding frontend/codegen
specific packages to be a TVMC mandatory dependency. For example, it's weird if
a user doesn't enable Xilinx flow in `config.cmake` but is asked to install
`pyxir` to run TVMC.
Maybe we should declare partition functions at one place and import related
dependencies lazily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
