FrozenGene commented on pull request #7573: URL: https://github.com/apache/tvm/pull/7573#issuecomment-793327449
> > If i don't understand it wrong, graph runtime we have done it before, but have not done for VM or other runtime. > > This PR is for graph runtime so it's not an issue for other runtimes? My concern is if we can reduce the API complexity from users. Now users need to use `tvm.contrib.cu_graph.cugraph_runtime.create(...)` to make use of this runtime, but this is not recommeneded. We should make all graph runtimes craeted from `graph_runtime.GraphModule`. Not it. I just meant our `GraphRuntimeFactory` has designed for this purpose you mentioned before. However, `GraphRuntimeFactory` is applied only for `GraphRuntime` now, not applied for VM or other runtime. But `GraphRuntimeFactory` could be used for the purpose you mentioned. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
