tqchen edited a comment on pull request #7710: URL: https://github.com/apache/tvm/pull/7710#issuecomment-803329092
Thanks @electriclilies ! There are quite a lot of previous practices (e.g. PyTorch, MXNet and TF's dataset API). It would be great to compare from these and make least amount of deviations so users can have a consistent usage experience per https://tvm.apache.org/docs/contribute/code_review.html#deliberate-on-api-and-data-structures ("Be consistent with existing well-known package’s APIs if the features overlap. ") Give this is an intro of a new feature, it would be great to send an RFC for broader discussion as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
