zxybazh commented on a change in pull request #7534:
URL: https://github.com/apache/tvm/pull/7534#discussion_r603708249



##########
File path: include/tvm/target/target.h
##########
@@ -168,5 +175,11 @@ class Target : public ObjectRef {
   TVM_DLL void ExitWithScope();
 };
 
+using TargetsMap = Map<Integer, Target>;
+
+TVM_DLL void RefreshHost(Target*, Target*);
+TVM_DLL void RefreshHost(TargetsMap*, Target*);
+TVM_DLL void RefreshHost(Map<Target, IRModule>*, Target*);

Review comment:
       I found that I cannot move the part of the helper function into the 
Target class because it requires a `Map<Target, ObjectRef>` type which cannot 
be compiled correctly. Therefore, I would put the functions outside the class 
for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to