tqchen commented on a change in pull request #7918:
URL: https://github.com/apache/tvm/pull/7918#discussion_r620534314
##########
File path: src/runtime/library_module.cc
##########
@@ -125,10 +125,11 @@ Module LoadModuleFromBinary(const std::string& type_key,
dmlc::Stream* stream) {
* \brief Load and append module blob to module list
* \param mblob The module blob.
* \param lib The library.
- *
- * \return Root Module.
+ * \param root_module the output root module
+ * \param dso_ctx_addr the output dso module
*/
-runtime::Module ProcessModuleBlob(const char* mblob, ObjectPtr<Library> lib) {
+void ProcessModuleBlob(const char* mblob, ObjectPtr<Library> lib,
runtime::Module* root_module,
+ runtime::ModuleNode** dso_ctx_addr = nullptr) {
Review comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
