hypercubestart commented on a change in pull request #7831:
URL: https://github.com/apache/tvm/pull/7831#discussion_r621330715
##########
File path: src/runtime/contrib/random/mt_random_engine.cc
##########
@@ -134,12 +134,16 @@ class RandomEngine {
private:
void FillData(DLTensor* tensor, int64_t size) {
- // Make the value be 1.0 - 10.0, not (0.0 - 1.0) so that we could satisfy
+ // Make the value be 17.0 - 30.0, not (0.0 - 1.0) so that we could satisfy
// quantized dtype (uint8 / int8) data non-empty requirement
- std::uniform_real_distribution<> dist(1.0, 10.0);
+ // We start from 17.0 because two int4 are packed in a single uint8
+ std::uniform_real_distribution<> dist(17.0, 30.0);
Review comment:
edited so that only int uses a different distribution from 17-30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
