areusch commented on a change in pull request #8014:
URL: https://github.com/apache/tvm/pull/8014#discussion_r631908084
##########
File path: python/tvm/relay/build_module.py
##########
@@ -115,6 +117,9 @@ def build(self, mod, target=None, target_host=None,
params=None, executor="graph
- If "graph" is specified, then the graph_executor will be used
- If "aot" is specified, then the aot_executor will be used
+ mod_name: Optional[str]
+ The module name we will build
Review comment:
cool, i agree with that. mangling is annoying because you have to be 1:1
and doing this may confuse the user. filesystems can handle a lot of strange
filenames now--I think C function names are the more restrictive use case of
`mod_name` now. Looks like the spec is digits, underscores, letters, and
escaped unicode chars. I'd suggest allowing all of that except the escaped
unicode. we don't have the restriction on the first char being a digit since we
will prefix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
