zotanika commented on a change in pull request #8015:
URL: https://github.com/apache/tvm/pull/8015#discussion_r634065680



##########
File path: python/tvm/relay/frontend/caffe.py
##########
@@ -558,6 +559,36 @@ def convert_tanh(self, op):
         out = _op.tanh(in_expr)
         return out
 
+    def convert_reduction(self, op):
+        """ Convert Reduction layer """
+        reduction_dic = ["NOP", "SUM", "ASUM", "SUMSQ", "MEAN"]

Review comment:
       `NOP` was placed in reduction_dic to remind users(and me) of the 
attribution of Caffe Reduction op, default operation `SUM` is starting from 
**1**; 
[https://caffe.berkeleyvision.org/tutorial/layers/reduction.html](https://caffe.berkeleyvision.org/tutorial/layers/reduction.html).
   If warning against the wrong attribution 0 is considered redundant, I'll 
remove it..
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to