altanh commented on pull request #8056:
URL: https://github.com/apache/tvm/pull/8056#issuecomment-845452140


   > Could you tell me how to decide to level of an op? And I could add the 
test to the correct place.
   
   Yep, sorry that the documentation of support level is lacking! We do have a 
doc at 
(https://tvm.apache.org/docs/langref/relay_op.html#overview-of-operators) but 
it seems outdated and missing quite a bit, so this needs to be improved. For 
this op, I think we can go with level 10 which matches the existing 
`nn.cross_entropy` op. I think we might want to remove this operator in the 
future since NLLLoss seems to be more general and subsumes it in my opinion, 
but that will be a separate PR :)
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to