akmaru commented on a change in pull request #7658:
URL: https://github.com/apache/tvm/pull/7658#discussion_r639177537
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -196,9 +196,9 @@ def compile_model(
for codegen_from_cli in extra_targets:
codegen =
composite_target.get_codegen_by_target(codegen_from_cli["name"])
partition_function = codegen["pass_pipeline"]
- mod = partition_function(mod, params)
+ mod, codegen_config = partition_function(mod, params)
if codegen["config_key"] is not None:
- config[codegen["config_key"]] = codegen_from_cli["opts"]
+ config[codegen["config_key"]] = codegen_from_cli["opts"] or
codegen_config
Review comment:
Sorry, I don't know it means.
The implementation before this change use all of `codegen_from_cli` as the
config.
If should consider only uses a part of `partiton_for_xxx`, it's due to not
this change but original implementation.
Or, should it apply also in this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
