comaniac commented on a change in pull request #7658:
URL: https://github.com/apache/tvm/pull/7658#discussion_r639197069
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -196,9 +196,9 @@ def compile_model(
for codegen_from_cli in extra_targets:
codegen =
composite_target.get_codegen_by_target(codegen_from_cli["name"])
partition_function = codegen["pass_pipeline"]
- mod = partition_function(mod, params)
+ mod, codegen_config = partition_function(mod, params)
if codegen["config_key"] is not None:
- config[codegen["config_key"]] = codegen_from_cli["opts"]
+ config[codegen["config_key"]] = codegen_from_cli["opts"] or
codegen_config
Review comment:
Sorry I misinterpreted the meaning of `codegen_from_cli` (their names
are sort of confusing...).
Since `codegen_from_cli` is given by each composite target, this way should
be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
