Lunderberg commented on pull request #8178: URL: https://github.com/apache/tvm/pull/8178#issuecomment-854818470
The check now works on all systems. For MSVC, undefined symbols already result in an error, no extra flag is needed. For MacOS, the equivalent `-Wl,-undefined,error` flag is used. I also switched to the equivalent but more readable `-Wl,--no-undefined` flag on linux. The check is applied only on libtvm.so and libtvm_runtime.so, and not to the more general `CMAKE_SHARED_LINKER_FLAGS`, because some of the other libraries have undefined symbols that are resolved when linking against the tvm libraries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
