mehrdadh commented on a change in pull request #8021:
URL: https://github.com/apache/tvm/pull/8021#discussion_r646803124
##########
File path: apps/microtvm/zephyr/host_driven/src/main.c
##########
@@ -214,33 +216,37 @@ tvm_crt_error_t TVMPlatformTimerStop(double*
elapsed_time_seconds) {
}
// Ring buffer used to store data read from the UART on rx interrupt.
-#define RING_BUF_SIZE_BYTES 4 * 1024
-RING_BUF_DECLARE(uart_rx_rbuf, RING_BUF_SIZE_BYTES);
-
-// Small buffer used to read data from the UART into the ring buffer.
-static uint8_t uart_data[8];
+// TODO(mehrdadh): Explore why offset is required.
Review comment:
I checked this on physical hardware and as you mentioned this large
value for ring buffer size is only required for testing on QEMU. I added a
comment about this. Please let me know if you have any other concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
