areusch commented on pull request #7742: URL: https://github.com/apache/tvm/pull/7742#issuecomment-873088794
@stoa let me discuss it with @tqchen a bit and get back to you. in general i'm okay with committing things in multiple stages, but this is quite a core interface so i'd not like to duplicate functionality. i think to some degree this is an organizational choice made by the codebase. at a high level, it makes sense to me that the conceptual c_runtime_api is a superset of c_backend_api. however, a confounding factor is that compiled functions can call PackedFunc e.g. defined inside the tvm codebase, and this pattern is prolific in the non-micro use case (C++ runtime). one question for you: do we need to block on this to merge the STM32 port? I think the main sticking point is TVMAPISetLastError, and I haven't been using that in the micro implementations (instead, I just return an error code to match [include/tvm/runtime/crt/error_codes.h](https://github.com/apache/tvm/blob/main/include/tvm/runtime/crt/error_codes.h) in place of the `-1` or `0` return value from the functions defined in `c_backend_api`. This serves as a better debugging aid without requiring a lot of strings in flash. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
