comaniac commented on a change in pull request #8464:
URL: https://github.com/apache/tvm/pull/8464#discussion_r669175601
##########
File path: src/relay/transforms/partition_graph.cc
##########
@@ -116,9 +116,11 @@ class Partitioner : public MixedModeMutator {
for (auto f : module->functions) {
GlobalVar f_var = f.first;
BaseFunc f_func = f.second;
+ std::string f_name = f_var.as<GlobalVarNode>()->name_hint;
Review comment:
Better to have a set here to make sure the function names are unqiue.
Something like:
```
while (func_names.find(f_name) != func_names.end()) {
f_name += "_a";
}
func_names.insert(f_name);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
