jcf94 commented on a change in pull request #8526:
URL: https://github.com/apache/tvm/pull/8526#discussion_r678784103
##########
File path: src/relay/backend/utils.h
##########
@@ -410,6 +416,15 @@ inline bool IsCompileEngineCacheDisabled() {
.value();
}
+/*!
+ * \brief Get a shared optimization pass prefix between vm and graph executor.
+ *
+ * \param targets The device type to `Target` mapping.
+ * \param is_vm A boolean indicating if the passes are used for vm or graph
executor.
+ * \return An array of passes.
+ */
+Array<Pass> GetPrefixOpts(const Map<tvm::Integer, tvm::Target>& targets, bool
is_vm);
Review comment:
Better to explain more clearly about what these passes will do, or come
up with a better function name.
But I don't have suggestions from my point of view ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
